Skip to content

chore: librarian update image pull request: 20260113T170734Z #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea wants to merge 1 commit into from
Closed

chore: librarian update image pull request: 20260113T170734Z #662

parthea wants to merge 1 commit into from

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Jan 13, 2026

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8

Generation failed for

  • google-cloud-datastore

@parthea
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-…
1095daf 
…prod/images-prod/python-librarian-generator@sha256:51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8
@parthea
Copy link
Contributor Author

parthea commented Jan 13, 2026

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: datastore Issues related to the googleapis/python-datastore API. labels Jan 13, 2026
@parthea parthea closed this Jan 13, 2026
@gemini-code-assist
Copy link

gemini-code-assist bot commented Jan 13, 2026

Summary of Changes

Hello @parthea, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the librarian image, which is responsible for generating client libraries. Due to a reported generation failure for the google-cloud-datastore library with the new image, the entire client library and its associated build and configuration files have been removed from the repository.

Highlights

  • Librarian Image Update: The librarian image used for automated code generation has been updated to a new SHA256 hash: 51d42b9060365aa10d21e64a370b82bf1e07ed7f1e46062dcb3ad10632b0acc8.
  • Removal of Google Cloud Datastore Client Library: The google-cloud-datastore client library, including its source code, documentation, and metadata files, has been entirely removed from the repository. This action was triggered by a reported generation failure for this specific library.
  • Deletion of Project Configuration Files: Several project-level configuration and build-related files, such as noxfile.py, renovate.json, and setup.py, have been deleted as part of this update.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 13, 2026
View reviewed changes
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated 'librarian' update that has failed for the google-cloud-datastore library. As a result, it includes the deletion of a vast number of critical source files, which would completely break the package. This is a critical issue. The only intentional change seems to be the generator image update in .librarian/state.yaml. Please investigate the generation failure and revert all the file deletions before this PR can be merged.

I am having trouble creating individual review comments. Click here to see my feedback.

setup.py (1-106)

critical

The deletion of setup.py and numerous other source files is highly problematic. As noted in the pull request description, the generation for google-cloud-datastore failed. These file deletions are likely an unintended side effect of that failure. Please revert these deletions to avoid breaking the package.

noxfile.py (1-539)

critical

This file, essential for testing and linting, has been deleted. This appears to be part of a broader issue in this PR where a failed generation process for google-cloud-datastore has led to the removal of many critical files. Please revert this deletion.

docs/README.rst (1-201)

critical

The main README file for the library has been deleted. This is likely an error caused by the failed generation process mentioned in the PR description. Please restore this file.

google/cloud/datastore_v1/init.py (1-226)

critical

The main __init__.py for the datastore_v1 client has been deleted, which would break all imports from this package. This is a critical error, likely caused by the failed generation. This deletion must be reverted.

google/cloud/datastore_admin_v1/init.py (1-174)

critical

The main __init__.py for the datastore_admin_v1 client has been deleted, which would break all imports from this package. This is a critical error, likely caused by the failed generation. This deletion must be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: datastore Issues related to the googleapis/python-datastore API. size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@parthea